Skip to content

CHANGE: Enable IMGUI Asset Editor for input action assets when UITK is available (ISX-1541)#1731

Merged
jfreire-unity merged 3 commits intodevelopfrom
isx-1541-enable-imgui-editor-for-assets
Aug 22, 2023
Merged

CHANGE: Enable IMGUI Asset Editor for input action assets when UITK is available (ISX-1541)#1731
jfreire-unity merged 3 commits intodevelopfrom
isx-1541-enable-imgui-editor-for-assets

Conversation

@jfreire-unity
Copy link
Copy Markdown
Collaborator

@jfreire-unity jfreire-unity commented Aug 15, 2023

Description

https://jira.unity3d.com/browse/ISX-1541

The UITK Editor view is only enabled for the Project Wide Actions Asset Editor, in the Project Settings.
Editing Input Action assets is done with the IMGUI Asset Editor.

Changes made

Added a isWindowEnabled field for the UITK Input Actions Asset Editor Window which is set to false.
Can be removed once UITK Asset Editor has enough feature parity with the IMGUI version.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@jfreire-unity
Enable IMGUI Asset Editor for custom input action assets
8afb163 
The UITK Editor view is only enabled for the Project Wide Actions Asset Editor, in the Project Settings.
lyndon-unity
lyndon-unity approved these changes Aug 17, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lyndon-unity lyndon-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable change.

Did you test that UI TK editing of the project wide input actions still works with this change though? It wasn't 100% clear from the description. (I'm not familiar with the flow where the project wide input actions opens the UI TK UI)

Also have you reviewed the Android / Mac CI failures. I'm sure I've seen the Android one on another branch but I'm concerned about the CI stability for input system.

@jfreire-unity
Copy link
Copy Markdown
Collaborator Author

jfreire-unity commented Aug 21, 2023

Looks reasonable change.

Did you test that UI TK editing of the project wide input actions still works with this change though? It wasn't 100% clear from the description. (I'm not familiar with the flow where the project wide input actions opens the UI TK UI)

@lyndon-unity yes, I checked that it works with #1720 branch.

Also have you reviewed the Android / Mac CI failures. I'm sure I've seen the Android one on another branch but I'm concerned about the CI stability for input system.

These are trunk only related issues that have been happening for all the recently merged PRs as well. We should fix them in a separate task.

@jfreire-unity jfreire-unity merged commit d426234 into develop Aug 22, 2023
@jfreire-unity jfreire-unity deleted the isx-1541-enable-imgui-editor-for-assets branch August 22, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyndon-unity lyndon-unity lyndon-unity approved these changes

@ritamerkl ritamerkl ritamerkl approved these changes

@jamesmcgill jamesmcgill Awaiting requested review from jamesmcgill

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jfreire-unity @lyndon-unity @ritamerkl